Update internvl.py, solve the exception when setting customized INPUT_SIZE. #4320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_SIZE. When user set customized 'input_size' instead of 448, the original version will raise exception, due to the dynamic of 'num_image_token'. we change the 'num_image_token' according to the 'input_size' dynamically.
Jintao-Huang
approved these changes
May 22, 2025
|
thanks! ❤️ |
|
Please run the following code: pip install pre-commit
pre-commit run --all-files |
|
|
|
|
|
改成这样试试 |
|
已修改，谢谢！ |
tastelikefeet
added a commit
to tastelikefeet/swift
that referenced
this pull request
May 23, 2025
…o_padding_ulysses * commit 'e9475f1a306614b30fc6314cc08eb5b40a3f17aa': qwen2_5_vl support video use image_dir (modelscope#4326) [megatron] Add extra args and provider support for easily customize megatron (modelscope#4240) Update internvl.py, solve the exception when setting customized INPUT_SIZE. (modelscope#4320) [grpo] support liger loss (modelscope#3781) compat transformer_engine update (modelscope#4317) compat transformers==4.52 (modelscope#4308) [grpo] support dp in external mode (modelscope#4279) fix vllm engine return empty in stream generation (modelscope#4303) fix (modelscope#4316) update swift image (modelscope#4309) update load_args (modelscope#4296) fix n > 1 with vLLM V1 Engine (modelscope#4295) Reuse existing code [grpo] fix num of reward_model > 1 (modelscope#4287) modify grpo system fix grpo tab support grpo web_ui # Conflicts: # swift/trainers/sequence_parallel/ulysses.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When user set customized 'input_size' instead of 448, the original version will raise exception, due to the dynamic of 'num_image_token'. we change the 'num_image_token' according to the 'input_size' dynamically.
PR type
PR information
Write the detail information belongs to this PR.
Experiment results
Paste your experiment result here(if needed).