Skip to content

fix: window.location.origin will be 'null' in iframe srcDoc #1956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2024
Merged

fix: window.location.origin will be 'null' in iframe srcDoc #1956

merged 1 commit into from
Jan 15, 2024

Conversation

2heal1
Copy link
Member

@2heal1 2heal1 commented Jan 12, 2024

Description

window.location.origin will be 'null' in iframe srcDoc
image

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

@2heal1 2heal1 merged commit b129098 into main Jan 15, 2024
@2heal1 2heal1 deleted the fix/iframe-src-doc branch January 15, 2024 03:37
@2heal1 2heal1 mentioned this pull request Jan 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScriptedAlchemy ScriptedAlchemy ScriptedAlchemy approved these changes

Assignees
No one assigned
Labels
change: fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2heal1 @ScriptedAlchemy