Skip to content

chore: disable unreliable e2e of next project #1972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2024
Merged

chore: disable unreliable e2e of next project #1972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e04ecf
test: disable unreliable e2e test in next
ScriptedAlchemy Jan 15, 2024
c22c382
test: disable unreliable e2e test in next
ScriptedAlchemy Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
run: npx nx run-many --target=serve --projects=3000-home,3001-shop,3002-checkout --parallel=3 & echo "done"

- name: E2E Test for 3000-home, 3001-shop, 3002-checkout
run: sleep 10 && npx nx run-many --target=test:e2e --projects=3000-home,3001-shop,3002-checkout --parallel=1
run: sleep 15 && npx nx run-many --target=test:e2e --projects=3000-home,3001-shop,3002-checkout --parallel=1

- name: Kill Processes on Ports 3000, 3001, 3002
run: lsof -ti tcp:3000,3001,3002 | xargs kill
Expand Down
5 changes: 3 additions & 2 deletions apps/3000-home/cypress/e2e/app.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,16 +31,17 @@ describe('3000-home/', () => {
});

describe('Routing checks', () => {
it('check that clicking back and forwards in client side routeing still renders the content correctly', () => {
xit('check that clicking back and forwards in client side routeing still renders the content correctly', () => {
cy.visit('/');
cy.visit('/shop');
cy.wait(3000);
cy.url().should('include', '/shop');
getH1().contains('Shop Page');
//eslint-disable-next-line
cy.wait(3000);
cy.get('.home-menu-link').contains('Home 3000');
cy.get('.home-menu-link').click();
cy.wait(1000);
cy.wait(2000);
cy.url().should('include', '/');
cy.wait(700);
getH1().contains('This is SPA combined');
Expand Down
6 changes: 3 additions & 3 deletions apps/3001-shop/cypress/e2e/app.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,17 +31,17 @@ describe('3001-shop/', () => {
});

describe('Routing checks', () => {
it('check that clicking back and forwards in client-side routing still renders the content correctly', () => {
xit('check that clicking back and forwards in client-side routing still renders the content correctly', () => {
cy.visit('/');
cy.visit('/shop');
cy.url().should('include', '/shop');
cy.wait(1000);
cy.wait(3000);
getH1().contains('Shop Page');
cy.wait(1000);
cy.get('.home-menu-link').click();
cy.wait(1000);
cy.get('.home-menu-link').click();
cy.wait(1000);
cy.wait(3000);
cy.url().should('include', '/');
cy.wait(1000);
getH1().contains('This is SPA combined');
Expand Down
7 changes: 4 additions & 3 deletions apps/3002-checkout/cypress/e2e/app.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,17 +31,18 @@ describe('3002-checkout/', () => {
});

describe('Routing checks', () => {
it('check that clicking back and forwards in client-side routing still renders the content correctly', () => {
xit('check that clicking back and forwards in client-side routing still renders the content correctly', () => {
cy.visit('/checkout');
cy.visit('/');
cy.visit('/checkout');
cy.wait(3000);
cy.url().should('include', '/checkout');
getH1().contains('checkout page');
cy.wait(1000);
cy.get('.home-menu-link').click();
cy.wait(1000);
cy.wait(2000);
cy.get('.home-menu-link').click();
cy.wait(8000);
cy.wait(2000);
cy.url().should('include', '/');
cy.wait(2000);
getH1().contains('This is SPA combined');
Expand Down