fi(node): AutoPublicPath plugin to use federation api to calculate public path automatically #1983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScriptedAlchemy
force-pushed
the
improve-public-path-
branch
from
0ec0b20 to
4e1d84c
Compare
ScriptedAlchemy
commented
Jan 17, 2024
| globalThis.__remote_scope__._config[remote], | ||
| ).pathname | ||
| .split('/') | ||
| .pop(); | ||
|
|
||
| // Construct the stats file URL from the remote config | ||
| //@ts-ignore |
There was a problem hiding this comment.
more work needed here, but there are other isssues beyond this that must be accounted for.
ScriptedAlchemy
changed the title
2heal1
approved these changes
Jan 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
removes tech debt around node.js and public path calculation which still relied on old globals.
Related Issue
Types of changes
Checklist