feat: Fetching index suggestions and dealing with the states CLOUDP-311786 #6887
Conversation
packages/compass-indexes/src/components/create-index-form/query-flow-section.tsx
Show resolved
Hide resolved
packages/compass-indexes/src/components/create-index-form/query-flow-section.tsx
Outdated
Show resolved
Hide resolved
| ); | ||
|
|
||
| const query = mql.parseQuery( | ||
| EJSON.parse(inputQuery, { relaxed: false }), |
There was a problem hiding this comment.
Does this work as expected with some queries? On a quick glance we might need to be parsing them with a different method. Should it be using this instead?
I might be wrong, haven't checked out the branch and tried it yet.
There was a problem hiding this comment.
it works for the most part but will break if there's a new line
working:
breaks:
There was a problem hiding this comment.
Does using an ObjectId type work?
{ _id: ObjectId("578f6fa2df35c7fbdbaed8f2") }There was a problem hiding this comment.
it did not so i updated it. now it works with object
| if (sampleDocuments === null) { | ||
| try { | ||
| sampleDocuments = | ||
| (await dataService.sample(namespace, { size: 50 })) || []; |
There was a problem hiding this comment.
I should mention, ideally we'd be passing an abort signal here, that way we can cancel the operation if the user closes the tab or something. I think this is fine as is for now, but something to keep in mind for future asynchronous things that allow for abort signals.
Description
https://jira.mongodb.org/browse/CLOUDP-311786
With data:
Loading:
NOTE: Error state to be fully implemented in another ticket, and create index with suggested index will also be in a separate ticket
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes