fix(logger): move log line earlier COMPASS-9736 #7231
Draft
+11
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR moves a log statement for connection success earlier in the connection flow to improve connection latency tracing for Data Explorer. The change relocates the log from after tracking and other post-connection operations to immediately after connection validation.
- Relocates the "Compass Connection Attempt Succeeded" log statement earlier in the connection flow
- Improves timing accuracy for Data Explorer connection latency tracing
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
gribnoysup
reviewed
Aug 27, 2025
| @@ -1792,6 +1792,17 @@ const connectWithOptions = ( | |||
| ); | |||
| } | |||
|
|
|||
| // This is used for Data Explorer connection latency tracing | |||
There was a problem hiding this comment.
Can you clarify and document why it's a fix and why it's important that this line is exactly here? Without this chances are high somebody will just move it again by accident
There was a problem hiding this comment.
Yeah, ideally I'm trynna see if I could just cover this with a test haha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moving the log line before the segment event tracking call
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes