-
Notifications
You must be signed in to change notification settings - Fork 105
feat: add atlas access list tools #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| import { z } from "zod"; | ||
| import { CallToolResult } from "@modelcontextprotocol/sdk/types.js"; | ||
| import { AtlasToolBase } from "./atlasTool.js"; | ||
| import { ToolArgs } from "../tool.js"; | ||
|
|
||
| const DEFAULT_COMMENT = "Added by Atlas MCP"; | ||
|
|
||
| export class CreateAccessListTool extends AtlasToolBase { | ||
| protected name = "atlas-create-access-list"; | ||
| protected description = "Allow Ip/CIDR ranges to access your MongoDB Atlas clusters."; | ||
| protected argsShape = { | ||
| projectId: z.string().describe("Atlas project ID"), | ||
| ipAddresses: z | ||
| .array(z.string().ip({ version: "v4" })) | ||
| .describe("IP addresses to allow access from") | ||
| .optional(), | ||
| cidrBlocks: z.array(z.string().cidr()).describe("CIDR blocks to allow access from").optional(), | ||
| comment: z.string().describe("Comment for the access list entries").default(DEFAULT_COMMENT).optional(), | ||
| }; | ||
|
|
||
| protected async execute({ | ||
| projectId, | ||
| ipAddresses, | ||
| cidrBlocks, | ||
| comment, | ||
| }: ToolArgs<typeof this.argsShape>): Promise<CallToolResult> { | ||
| await this.ensureAuthenticated(); | ||
|
|
||
| if (!ipAddresses?.length && !cidrBlocks?.length) { | ||
| throw new Error("Either ipAddresses or cidrBlocks must be provided."); | ||
| } | ||
|
|
||
| const ipInputs = (ipAddresses || []).map((ipAddress) => ({ | ||
| groupId: projectId, | ||
| ipAddress, | ||
| comment: comment || DEFAULT_COMMENT, | ||
| })); | ||
|
|
||
| const cidrInputs = (cidrBlocks || []).map((cidrBlock) => ({ | ||
| groupId: projectId, | ||
| cidrBlock, | ||
| comment: comment || DEFAULT_COMMENT, | ||
| })); | ||
|
|
||
| const inputs = [...ipInputs, ...cidrInputs]; | ||
|
|
||
| await this.apiClient.createProjectIpAccessList(projectId, inputs); | ||
|
|
||
| return { | ||
| content: [ | ||
| { | ||
| type: "text", | ||
| text: `IP/CIDR ranges added to access list for project ${projectId}.`, | ||
| }, | ||
| ], | ||
| }; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| import { z } from "zod"; | ||
| import { CallToolResult } from "@modelcontextprotocol/sdk/types.js"; | ||
| import { AtlasToolBase } from "./atlasTool.js"; | ||
| import { ToolArgs } from "../tool.js"; | ||
|
|
||
| export class InspectAccessListTool extends AtlasToolBase { | ||
| protected name = "atlas-inspect-access-list"; | ||
| protected description = "Inspect Ip/CIDR ranges with access to your MongoDB Atlas clusters."; | ||
| protected argsShape = { | ||
| projectId: z.string().describe("Atlas project ID"), | ||
| }; | ||
|
|
||
| protected async execute({ projectId }: ToolArgs<typeof this.argsShape>): Promise<CallToolResult> { | ||
| await this.ensureAuthenticated(); | ||
|
|
||
| const accessList = await this.apiClient.listProjectIpAccessLists(projectId); | ||
|
|
||
| if (!accessList.results?.length) { | ||
| throw new Error("No access list entries found."); | ||
| } | ||
|
|
||
| return { | ||
| content: [ | ||
| { | ||
| type: "text", | ||
| text: | ||
| `IP ADDRESS | CIDR | COMMENT | ||
| ------|------|------ | ||
| ` + | ||
| (accessList.results || []) | ||
| .map((entry) => { | ||
| return `${entry.ipAddress} | ${entry.cidrBlock} | ${entry.comment}`; | ||
| }) | ||
| .join("\n"), | ||
| }, | ||
| ], | ||
| }; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we default to the device's public IP address? Alternatively, we can lookup the current IP address and respond with a prompt whether to add it - something like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for pointing out, I'll handle current ips on a follow up PR, I'll check if makes sense to have a resource for this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added #36