-
Notifications
You must be signed in to change notification settings - Fork 96
chore: specify the correct minimum node requirements #378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Node.js version requirements in package.json to be more specific about supported versions, moving from a broad minimum requirement to explicit version ranges for Node.js 20, 22, and 23.
- Updates the engines.node field to specify exact supported version ranges instead of a single minimum version
- Establishes clear compatibility boundaries for Node.js v20.19.0+, v22.12.0+, and v23.0.0+
@@ -74,6 +74,6 @@ | |||
"zod": "^3.25.76" | |||
}, | |||
"engines": { | |||
"node": ">=20.19.0" | |||
"node": "^20.19.0 || ^22.12.0 || >= 23.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version constraint syntax is inconsistent. The third range uses '>= 23.0.0' while the first two use caret ranges (^). Consider using '^23.0.0' for consistency, or if you specifically need all v23+ versions, document why this range differs from the others.
"node": "^20.19.0 || ^22.12.0 || >= 23.0.0" | |
"node": "^20.19.0 || ^22.12.0 || ^23.0.0" |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Versions >= 23.0.0 support requiring esm by default
Pull Request Test Coverage Report for Build 16347477296Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if we decide to bundle everything into CJS, I think we need to specify the correct engine as there are libraries that we already use that complain when used in older versions from users that opened issues in this repo.
@himanshusinghs can you update the |
Ahh yea thanks for reminding me of this - I will do that. |
Works for me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally we want to have lower limits but yes this reflects the current reality
I think this needs |
Its updated now - I was not on correct branch (too much switching 🤦) |
Proposed changes
The version constraint earlier was pretty broad and did not really encapsulate the correct minimum requirements when it came to v22 and v23. This commit fixes that.
Checklist