Fix handling of _version.py file #187
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| test_dist: | ||
| needs: [build_dist] | ||
| name: Test Distribution Files | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
| persist-credentials: false | ||
|
|
||
| - uses: actions/setup-python@v5 | ||
| with: | ||
| # Build sdist on lowest supported Python | ||
| python-version: '3.9' | ||
|
|
||
| - name: Download the dists | ||
| uses: actions/download-artifact@v4 | ||
| with: | ||
| name: dist-${{ github.run_id }} | ||
| path: dist/ | ||
|
|
||
| - name: Test the sdist | ||
| run: | | ||
| cd dist | ||
| pip install *.tar.gz | ||
| python -c "import flask_pymongo" | ||
| pip uninstall -y flask_pymongo | ||
|
|
||
| - name: Test the wheel | ||
| run: | | ||
| cd dist | ||
| pip install *.whl | ||
| python -c "import flask_pymongo" | ||
| pip uninstall -y flask_pymongo |
Check warning
Code scanning / zizmor
overly broad permissions Warning
There was a problem hiding this comment.
What is this alert for?
| test_dist: | ||
| needs: [build_dist] | ||
| name: Test Distribution Files | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
| persist-credentials: false | ||
|
|
||
| - uses: actions/setup-python@v5 | ||
| with: | ||
| # Build sdist on lowest supported Python | ||
| python-version: '3.9' | ||
|
|
||
| - name: Download the dists | ||
| uses: actions/download-artifact@v4 | ||
| with: | ||
| name: dist-${{ github.run_id }} | ||
| path: dist/ | ||
|
|
||
| - name: Test the sdist | ||
| run: | | ||
| cd dist | ||
| pip install *.tar.gz | ||
| python -c "import flask_pymongo" | ||
| pip uninstall -y flask_pymongo | ||
|
|
||
| - name: Test the wheel | ||
| run: | | ||
| cd dist | ||
| pip install *.whl | ||
| python -c "import flask_pymongo" | ||
| pip uninstall -y flask_pymongo |
There was a problem hiding this comment.
What is this alert for?
| @@ -6,8 +6,6 @@ _build | |||
| dist/ | |||
| *.pyc | |||
| .pytest_cache/ | |||
| _version.py | |||
| version.txt | |||
There was a problem hiding this comment.
So these files are untracked but expected to be included in the distribution? How do we prevent committing them?
There was a problem hiding this comment.
This repo used to use setuptools-scm. Now that we use hatch, we want the version file to be there.
There was a problem hiding this comment.
Shouldn't this PR be adding the file in that case?
There was a problem hiding this comment.
The file was already there, hatch uses .gitignore to determine what goes into the dist by default, unless you override it.
There was a problem hiding this comment.
Oh I see the file already exists. I forgot you could commit a .gitignore file.
Fixes #186. Hatch was using the
.gitignorefile to determine which files to include in the dists.