Skip to content

Use linked-hash-map to implement OrderedDocument #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zonyitoo opened this issue Mar 5, 2016 · 2 comments
Closed

Use linked-hash-map to implement OrderedDocument #35

zonyitoo opened this issue Mar 5, 2016 · 2 comments
Labels
enhancement

Comments

@zonyitoo
Copy link
Contributor

zonyitoo commented Mar 5, 2016

The ordered::OrderedDocument is a temporary solution while the linked-hash-map crate can only be compiled with nightly. But now, linked-hash-map can be compiled with the latest stable rustc v1.7 (contain-rs/linked-hash-map#28).

So I suggest that we could migrate it to linked-hash-map.
@zonyitoo zonyitoo mentioned this issue Mar 5, 2016
Closed
zonyitoo added a commit that referenced this issue Mar 6, 2016
@zonyitoo
[#35] use linked-hash-map
a911bc8
@zonyitoo zonyitoo changed the title Use linked-hash-map to replace OrderedDocument Use linked-hash-map to implement OrderedDocument Mar 6, 2016
@zonyitoo zonyitoo mentioned this issue Mar 6, 2016
Merged
zonyitoo added a commit that referenced this issue Mar 6, 2016
@zonyitoo
[#35] use linked-hash-map
2d3cddc
@dariusc93
Copy link

How would this impact current use of bson?

@zonyitoo
Copy link
Contributor Author

zonyitoo commented Mar 7, 2016

Currently the OrderedDocument is implemented as Vec + BTreeMap pair to maintain insertion order. Which means that we need to do a O(n) search on the Vec and store the String key twice.

Using LinkedHashMap will help to increase performance.

zonyitoo added a commit that referenced this issue Mar 9, 2016
@zonyitoo
[#35, #33] use linked-hash-map, make ordered module public
10de77d
@zonyitoo zonyitoo closed this as completed Mar 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zonyitoo @dariusc93