-
Notifications
You must be signed in to change notification settings - Fork 28
DRIVERS-2917 - Standardized Performance Testing of ODMs and Integrations #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
NoahStapp
wants to merge
15
commits into
mongodb:main
Choose a base branch
from
NoahStapp:DRIVERS-2917
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
90ecd0c
Initial WIP
NoahStapp d1d6e84
First draft of flat model benchmarks
NoahStapp 4db9461
Finish first draft of benchmarks
NoahStapp 02798aa
Linting
NoahStapp c4ba5ce
Linting again
NoahStapp f7e7345
Omit perf tests from runtests
NoahStapp 316258f
Add Evergreen automation for perf tests
NoahStapp 58f27da
Fix perf test path
NoahStapp 84b5fff
Fix report and result paths
NoahStapp e9acd6b
Use original benchmark params
NoahStapp 7c07dfc
Added copyright + documentation
NoahStapp a6c5df9
Address Tim review
NoahStapp dc32d06
Use Model.objects.create() where possible
NoahStapp f97ef89
More review changes
NoahStapp c03d78b
include_expansions_in_env array
NoahStapp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
#!/bin/bash | ||
# We use the requester expansion to determine whether the data is from a mainline evergreen run or not | ||
|
||
set -eu | ||
|
||
# shellcheck disable=SC2154 | ||
if [ "${requester}" == "commit" ]; then | ||
echo "is_mainline: true" >> expansion.yml | ||
else | ||
echo "is_mainline: false" >> expansion.yml | ||
fi | ||
|
||
# We parse the username out of the order_id as patches append that in and SPS does not need that information | ||
# shellcheck disable=SC2154 | ||
echo "parsed_order_id: $(echo "${revision_order_id}" | awk -F'_' '{print $NF}')" >> expansion.yml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
#!/bin/bash | ||
# We use the requester expansion to determine whether the data is from a mainline evergreen run or not | ||
|
||
set -eu | ||
|
||
# Submit the performance data to the SPS endpoint | ||
# shellcheck disable=SC2154 | ||
response=$(curl -s -w "\nHTTP_STATUS:%{http_code}" -X 'POST' \ | ||
"https://performance-monitoring-api.corp.mongodb.com/raw_perf_results/cedar_report?project=${project_id}&version=${version_id}&variant=${build_variant}&order=${parsed_order_id}&task_name=${task_name}&task_id=${task_id}&execution=${execution}&mainline=${is_mainline}" \ | ||
-H 'accept: application/json' \ | ||
-H 'Content-Type: application/json' \ | ||
-d @results.json) | ||
|
||
http_status=$(echo "$response" | grep "HTTP_STATUS" | awk -F':' '{print $2}') | ||
response_body=$(echo "$response" | sed '/HTTP_STATUS/d') | ||
|
||
# We want to throw an error if the data was not successfully submitted | ||
if [ "$http_status" -ne 200 ]; then | ||
echo "Error: Received HTTP status $http_status" | ||
echo "Response Body: $response_body" | ||
exit 1 | ||
fi | ||
|
||
echo "Response Body: $response_body" | ||
echo "HTTP Status: $http_status" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
#!/usr/bin/bash | ||
|
||
set -eux | ||
|
||
export OUTPUT_FILE="results.json" | ||
|
||
# Install django-mongodb-backend | ||
/opt/python/3.10/bin/python3 -m venv venv | ||
. venv/bin/activate | ||
python -m pip install -U pip | ||
pip install -e . | ||
|
||
python .evergreen/run_perf_test.py | ||
mv tests/performance/$OUTPUT_FILE $OUTPUT_FILE | ||
mv tests/performance/report.json report.json |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
import json | ||
import logging | ||
import os | ||
import shlex | ||
import subprocess | ||
import sys | ||
from datetime import datetime | ||
|
||
LOGGER = logging.getLogger("test") | ||
logging.basicConfig(level=logging.INFO, format="%(levelname)-8s %(message)s") | ||
OUTPUT_FILE = os.environ.get("OUTPUT_FILE") | ||
|
||
|
||
def handle_perf(start_time: datetime): | ||
end_time = datetime.now() | ||
elapsed_secs = (end_time - start_time).total_seconds() | ||
with open(OUTPUT_FILE) as fid: # noqa: PTH123 | ||
results = json.load(fid) | ||
LOGGER.info("results.json:\n%s", json.dumps(results, indent=2)) | ||
|
||
results = { | ||
"status": "PASS", | ||
"exit_code": 0, | ||
"test_file": "BenchMarkTests", | ||
"start": int(start_time.timestamp()), | ||
"end": int(end_time.timestamp()), | ||
"elapsed": elapsed_secs, | ||
} | ||
report = {"results": [results]} | ||
|
||
LOGGER.info("report.json\n%s", json.dumps(report, indent=2)) | ||
|
||
with open("report.json", "w", newline="\n") as fid: # noqa: PTH123 | ||
json.dump(report, fid) | ||
|
||
|
||
def run_command(cmd: str | list[str], **kwargs) -> None: | ||
if isinstance(cmd, list): | ||
cmd = " ".join(cmd) | ||
LOGGER.info("Running command '%s'...", cmd) | ||
kwargs.setdefault("check", True) | ||
try: | ||
subprocess.run(shlex.split(cmd), **kwargs) # noqa: PLW1510, S603 | ||
except subprocess.CalledProcessError as e: | ||
LOGGER.error(e.output) | ||
LOGGER.error(str(e)) | ||
sys.exit(e.returncode) | ||
LOGGER.info("Running command '%s'... done.", cmd) | ||
|
||
|
||
os.chdir("tests/performance") | ||
|
||
start_time = datetime.now() | ||
run_command(["python manage.py test"]) | ||
handle_perf(start_time) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -157,7 +157,8 @@ | |
x.name | ||
for x in (pathlib.Path(__file__).parent.parent.parent.resolve() / "tests").iterdir() | ||
# Omit GIS tests unless GIS libraries are installed. | ||
if x.name != "gis_tests_" | ||
# Always omit the performance benchmarking suite. | ||
if x.name != "gis_tests_" and x.name != "performance" | ||
Comment on lines
+160
to
+161
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💯 |
||
] | ||
), | ||
] | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
#!/usr/bin/env python | ||
"""Django's command-line utility for administrative tasks.""" | ||
|
||
import os | ||
import sys | ||
|
||
|
||
def main(): | ||
"""Run administrative tasks.""" | ||
os.environ.setdefault("DJANGO_SETTINGS_MODULE", "perftest.settings") | ||
try: | ||
from django.core.management import execute_from_command_line # noqa: PLC0415 | ||
except ImportError as exc: | ||
raise ImportError( | ||
"Couldn't import Django. Are you sure it's installed and " | ||
"available on your PYTHONPATH environment variable? Did you " | ||
"forget to activate a virtual environment?" | ||
) from exc | ||
execute_from_command_line(sys.argv) | ||
|
||
|
||
if __name__ == "__main__": | ||
main() |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT:
Whilst I'd rather not have a new dependency on
drivers-evergreen-tools
, to future-proof the binary usage, you could add in thefind_python
functionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This I copied over from the existing
run-tests.sh
script here. Let's update them both in a separate ticket.