Skip to content

(DOCSP-29167): Kotlin Flow docs #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 14, 2023
Merged

Conversation

mongodben
Copy link
Collaborator

@mongodben mongodben commented May 12, 2023

Pull Request Info

Kotlin Flow docs

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-29167
Staging - https://docs-mongodbcom-staging.corp.mongodb.com/kotlin/docsworker-xlarge/DOCSP-29167/fundamentals/crud/read-operations/flow

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?

@mongodben mongodben requested a review from cbullinger May 12, 2023 14:45
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note to tech reviewer: this page was adapted from the java cursor page.

i kept the content that seemed relevant, in addition to reorienting the page around flows.

Copy link
Collaborator

@cbullinger cbullinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy lgtm. I'll defer to Jeff as to whether we need additional info

@mongodben mongodben requested a review from jyemin May 18, 2023 15:54
Copy link
Collaborator

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should hold off on this until https://jira.mongodb.org/browse/JAVA-4950 is resolved.

@mongodben mongodben added the Must Have Must have docs for .local NYC label May 22, 2023
@mongodben mongodben requested review from rozza and removed request for rozza June 8, 2023 14:31
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbullinger cbullinger merged commit a1fe183 into mongodb:master Jun 14, 2023
rustagir pushed a commit that referenced this pull request Jun 14, 2023
# Pull Request Info

Kotlin Flow docs

[PR Reviewing
Guidelines](https://github.com/mongodb/docs-java/blob/master/REVIEWING.md)

JIRA - https://jira.mongodb.org/browse/DOCSP-29167
Staging -
https://docs-mongodbcom-staging.corp.mongodb.com/kotlin/docsworker-xlarge/DOCSP-29167/fundamentals/crud/read-operations/flow

## Self-Review Checklist

- [ ] Is this free of any warnings or errors in the RST?
- [ ] Did you run a spell-check?
- [ ] Did you run a grammar-check?
- [ ] Are all the links working?

---------

Co-authored-by: cbullinger <[email protected]>
cbullinger added a commit to cbullinger/docs-kotlin that referenced this pull request Jun 18, 2023
# Pull Request Info

Kotlin Flow docs

[PR Reviewing
Guidelines](https://github.com/mongodb/docs-java/blob/master/REVIEWING.md)

JIRA - https://jira.mongodb.org/browse/DOCSP-29167
Staging -
https://docs-mongodbcom-staging.corp.mongodb.com/kotlin/docsworker-xlarge/DOCSP-29167/fundamentals/crud/read-operations/flow

## Self-Review Checklist

- [ ] Is this free of any warnings or errors in the RST?
- [ ] Did you run a spell-check?
- [ ] Did you run a grammar-check?
- [ ] Are all the links working?

---------

Co-authored-by: cbullinger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Must Have Must have docs for .local NYC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants