Skip to content

fix(NODE-3390): serialize non-finite doubles correctly in EJSON #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2021
Merged

fix(NODE-3390): serialize non-finite doubles correctly in EJSON #445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/extended_json.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ function serializeValue(value: any, options: EJSONSerializeOptions): any {
: { $date: { $numberLong: value.getTime().toString() } };
}

if (typeof value === 'number' && !options.relaxed) {
if (typeof value === 'number' && (!options.relaxed || !isFinite(value))) {
// it's an integer
if (Math.floor(value) === value) {
const int32Range = value >= BSON_INT32_MIN && value <= BSON_INT32_MAX,
Expand Down
9 changes: 9 additions & 0 deletions test/node/extended_json_tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,15 @@ describe('Extended JSON', function () {
expect(serialized).to.equal('42');
});

it('should correctly serialize non-finite numbers', function () {
const numbers = { neginf: -Infinity, posinf: Infinity, nan: NaN };
const serialized = EJSON.stringify(numbers);
expect(serialized).to.equal(
'{"neginf":{"$numberDouble":"-Infinity"},"posinf":{"$numberDouble":"Infinity"},"nan":{"$numberDouble":"NaN"}}'
);
expect(EJSON.parse(serialized)).to.deep.equal(numbers);
});

it('should correctly parse null values', function () {
expect(EJSON.parse('null')).to.be.null;
expect(EJSON.parse('[null]')[0]).to.be.null;
Expand Down