Skip to content

fix(NODE-3493): code and symbol tests are partially testing the wrong types #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2021
Merged

fix(NODE-3493): code and symbol tests are partially testing the wrong types #459

merged 2 commits into from
Sep 23, 2021

Conversation

nbbeeken
Copy link
Contributor

Fixes: NODE-3493

@nbbeeken nbbeeken requested a review from dariakp September 17, 2021 20:02
dariakp
dariakp reviewed Sep 17, 2021
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's check the performance on this before merging

@dariakp dariakp merged commit 80d7f03 into master Sep 23, 2021
@dariakp dariakp deleted the NODE-3493/code-and-symbol branch September 23, 2021 16:13
@github-actions github-actions bot mentioned this pull request May 7, 2024
Closed
@github-actions github-actions bot mentioned this pull request Jun 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariakp dariakp dariakp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @dariakp