-
Notifications
You must be signed in to change notification settings - Fork 1.5k
DOCSP-35947: write operations modify documents #2808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ccho-mongodb
merged 26 commits into
mongodb:4.1-base-docs-write-operations
from
ccho-mongodb:DOCSP-35947-write-operations-modify-documents
Apr 8, 2024
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
8fbbcc4
DOCSP-35948: Write operations
a5a75ca
add examples
a678179
apply phpcbf formatting
ccho-mongodb eea96e5
wip
88024a5
apply phpcbf formatting
ccho-mongodb 24fdd13
add date info
77bdbec
apply phpcbf formatting
ccho-mongodb 831f06e
update title of read operations
d813f23
grammar fixes
a194e60
DOCSP-35947: write operations - modify documents
2582bd5
apply phpcbf formatting
ccho-mongodb 86ff663
misc fixes
4dc106a
rst fixes
678490e
fixes
8ff6872
fix
44eb655
fix
60a6cfb
fix rst
a9d072c
concise sentence
79037d2
linebreaks
78bc0e7
double backslash
1d77153
fix
146cecb
PRR fixes
39dc447
PRR fixes 2
cfac53e
PRR fixes 3
1e6269f
remove comments from tests
70fbf47
Merge branch '4.1-base-docs-write-operations' into DOCSP-35947-write-…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: not necessary, but I like the detailed description of the code example in lines 86-94. Could be helpful to introduce this code example with more specific info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there specific info that you think might be helpful to add? I think the insert example adds type information which sets up the rest of the examples on the page, but could be repetitive and draw away from the focus of the rest of the examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking of specifying which fields / values you're updating (
venue
,ticketsSold
), but agreed that this could be repetitive and I think it's fine as is!