Skip to content

CDRIVER-4608 Reload expansions before deleting Azure resources #1234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

kevinAlbs
Copy link
Collaborator

@kevinAlbs kevinAlbs commented Apr 7, 2023

Summary

  • Reload expansions before deleting Azure resources

Verified by this patch

Background & Motivation

This is an improvement to the testazurekms_task_group added as part of DRIVERS-2411.

If setup_group fails before running expansions.update, the teardown_group will not have the required expansions to delete resources.

Here is an example failure in setup_group. The logs in teardown_group show the delete-vm.sh script failing to run:

[2023/04/07 15:50:54.776] Please set the following required environment variables
[2023/04/07 15:50:54.776]  AZUREKMS_RESOURCEGROUP
[2023/04/07 15:50:54.776]  AZUREKMS_VMNAME

This results in the Azure resources not being deleted.

With changes in this PR, a failure in setup_group results in the Azure resources being deleted:

[2023/04/07 16:05:18.111] Deleting Virtual Machine vmname-CDRIVER-8130 ... begin
[2023/04/07 16:05:18.112] Deleting Virtual Machine vmname-CDRIVER-8130 ... end
[2023/04/07 16:05:18.112] Delete public IP vmname-CDRIVER-8130-PUBLIC-IP ... begin
[2023/04/07 16:05:40.172] Delete public IP vmname-CDRIVER-8130-PUBLIC-IP ... end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants