GODRIVER-2616 Change CommandFailedEvent.Failure type to error #1469
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvasquez
requested review from
matthewdale
and removed request for
a team
API Change Report./eventincompatible changesCommandFailedEvent.Failure: changed from string to error |
blink1073
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2616
Summary
Change CommadFailedEvent.Failure type from string to error.
Background & Motivation
The original proposal for the command monitoring event api was given in ecbcd69 . It is unclear why a string type was chosen for failure. The specifications concerning a failed event states the following about the failure type:
Since a Go error is a wrapper for a function that returns a string, I think it is reasonable to assume that a Go error falls under the "string" type.
The original POC is given in PR #1105