Update govulncheck Go version and mark the command as type 'test'. #2208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the govulncheck script to use Go 1.25.1 instead of 1.24.5 to avoid vulnerability reports for the Go version itself, and correctly marks the govulncheck command as type "test" in the Evergreen configuration.
- Update Go version in govulncheck script from 1.24.5 to 1.25.1
- Mark govulncheck command as type "test" instead of "setup" in Evergreen config
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| etc/govulncheck.sh | Updates GO_VERSION to avoid vulnerability in Go 1.24.5 |
| .evergreen/config.yml | Adds type "test" to govulncheck command for proper failure categorization |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
matthewdale
added
review-priority-urgent
🧪 Performance ResultsCommit SHA: 44cc1c8There were no significant changes to the performance to report for version 68d607896a0a5c0007de8898.
For a comprehensive view of all microbenchmark results for this PR's commit, please check out the Evergreen perf task for this patch. |
API Change ReportNo changes found! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bump the Go version in the govulncheck script to the latest Go version. Also mark the govulncheck command in the Evergreen config as type "test".
Background & Motivation
Go 1.24.5 is subject to vulnerability GO-2025-3849, so that shows up in the
govulncheckoutput. Also, the govulncheck command in the Evergreen config is currently type "setup", so failures are incorrectly marked as setup failures.