simple DML translation #102
Conversation
| }); | ||
| } | ||
|
|
||
| public static final class MutateTranslatorAwareDialect extends Dialect { |
There was a problem hiding this comment.
An important feature to test is we need to include the table names involved in DML queries into the result of SqlAstTranslator#getAffectedTableNames() which acts as auto-flush purpose in the upper level caller of the translator.
We might need to finish other features (like table joining) to test the auto-flush features in integration test; currently we could only test this important feature by some expedient.
There was a problem hiding this comment.
It is. related to auto-flushing criteria No..2 (see https://docs.jboss.org/hibernate/orm/6.6/userguide/html_single/Hibernate_User_Guide.html#flushing-auto):
- prior to executing a JPQL/HQL query that overlaps with the queued entity actions
| @@ -36,17 +38,17 @@ | |||
|
|
|||
| @SessionFactory(exportSchema = false) | |||
| @ExtendWith(MongoExtension.class) | |||
| abstract class AbstractSelectionQueryIntegrationTests implements SessionFactoryScopeAware, ServiceRegistryScopeAware { | |||
| public abstract class AbstractQueryIntegrationTests implements SessionFactoryScopeAware, ServiceRegistryScopeAware { | |||
There was a problem hiding this comment.
this class is reusable not only for select query but also for mutate query, so it is renamed and moved to more general location. The Book class was changed accordingly to go together with it hand in hand.
| throw new FeatureNotSupportedException("Unsupported mutation statement type: " | ||
| + mutationStatement.getClass().getName()); | ||
| } | ||
| } |
There was a problem hiding this comment.
currently there is no fourth class of MutationStatement; the above last else clause is for future-proof purpose.
NathanQingyangXu
force-pushed
the
HIBERNATE-46
branch
from
25d8fb7 to
8e2cee5
Compare
src/main/java/com/mongodb/hibernate/internal/translate/mongoast/command/AstInsertCommand.java
Outdated
Show resolved
Hide resolved
NathanQingyangXu
force-pushed
the
HIBERNATE-46
branch
from
8e2cee5 to
55ab573
Compare
…t/command/AstInsertCommand.java Co-authored-by: Jeff Yemin <[email protected]>
| checkMutationStatement(insertStatement); | ||
| if (insertStatement.getConflictClause() != null) { | ||
| throw new FeatureNotSupportedException(); | ||
| } |
There was a problem hiding this comment.
HQL has an interesting ON CONFLICT during insertion feature (see https://www.baeldung.com/hibernate-insert-query-on-conflict-clause). It is sort of similar to MongoDB's upsert feature but it seems there is a big difference between them:
- HQL mainly focuses on conflict during insertion (w.r.t. unique constraint or fields combination); MongoDB's
upsertfocuses on conflict during updating (w.r.t. some query or filter,, e.g. comparison between a field and a value)
So I guess we can't support this HQL feature. HQL's update statement is simpler and provides no possibility to emulate MongoDB's upsert feature.
| } | ||
| if (insertStatement.getSourceSelectStatement() != null) { | ||
| throw new FeatureNotSupportedException(); | ||
| } |
There was a problem hiding this comment.
HQL has two flavours of insertion statement:
insert into Book (id, title) values (1, "War and Peace"), (2, "Crime and Punishment")insert into Book (id, title) select c.identifier, c.name from Catalog as c
This PR will focus on the first variant and throw exception for the latter.
| documents.add(new AstDocument(astElements)); | ||
| } | ||
|
|
||
| astVisitorValueHolder.yield(COLLECTION_MUTATION, new AstInsertCommand(collection, documents)); |
There was a problem hiding this comment.
there are 3 assertion usages above as follows:
- insertion field list is not empty
- insertion values list is not empty
- field list length is the same as values length
The above constraints were either enforced from HQL grammar level or semantic checking phase in Hibernate (a prior step when the final SQL AST translation step is reached), so we can rest assured these constraints are enforced already.
There was a problem hiding this comment.
similarly, various assertions are used in updating case as well. Common constraints have been carefully centralized into checkMutationStatementSupportability() method. Only one checking is required to ensure the insertion field value or udpating field value expressions should be either valueExpression (literal value or parameter expressions).
NathanQingyangXu
force-pushed
the
HIBERNATE-46
branch
from
42d2b77 to
5c7a58d
Compare
NathanQingyangXu
force-pushed
the
HIBERNATE-46
branch
2 times, most recently
from
0cc0a35 to
4d24c09
Compare
NathanQingyangXu
force-pushed
the
HIBERNATE-46
branch
from
4d24c09 to
6558ab1
Compare
https://jira.mongodb.org/browse/HIBERNATE-46
The scope of the ticket is to unblock the following simple DML HQL mutation queries:
insert into Book (id, title) values (1, "War and Peace"), (2, "Crime and Punishmnet")update Book set title = "War and Peace" where title = "War & Peace"delete from Book where title = "War and Peace"Translation is straightforward. The following new visitor methods would be implemented in this PR:
Both of the first two methods share a lot in common in the sense that they are both based on where clause, with various AST filters as the backbones, which has been finished in previous PR.
The scope of this PR is modest and only focuses on the following basic stuff:
$setupdating operator is supported (with the constraint that$setfocuses on field path and value pair)One caveat is previously our insertion command mongo ast only allows one document, to fully support HQL's feature, the mongo ast model was refactored to allow multiple documents, consistent with MQL's syntax as well. There is a separate ticket for this requirment: https://jira.mongodb.org/browse/HIBERNATE-44, so we can finish it in this PR additionally.