Implement visitBooleanExpressionPredicate

[NathanQingyangXu]

https://jira.mongodb.org/browse/HIBERNATE-78

A straightforward ticket

[vbabanin]

Suggested change

	SessionFactoryScope sessionFactoryScope;
	protected SessionFactoryScope sessionFactoryScope;

[stIncMale]

protected is more permissive than package-access, and making program elements more accessible than needed is something that we agreed not to do. Does this field and testCommandListener have to be protected?

[NathanQingyangXu]

well, from visibility perspective, protected is not mandatory; but it is also a good practice to use protected on abstract class to denote it is accessible to any child class, regardless of whether the child class resides in the same package or not. it is more about semantic connotation.

For that reason, I want to follow @vbabanin's suggestions.

[vbabanin]

I initially assumed this class might be reused across packages. However, if it’s meant to be used only within the same package and based on the earlier discussions - package-private should be more appropriate.

[NathanQingyangXu]

I switched to package-private for the following two methods:

    SessionFactoryScope getSessionFactoryScope() {
        return sessionFactoryScope;
    }

    TestCommandListener getTestCommandListener() {
        return testCommandListener;
    }

[NathanQingyangXu]

@vbabanin , I completed the assertion overloaded methods without null query post processor at b420a2d

[vbabanin]

LGTM!

[stIncMale]

Skimmed through, did not review.