-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Use AWS SDK v2/v1 if available for AWS credential fetching #1017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
bafd510
Use AWS SDK v2 if available for AWS credential fetching
jyemin c23563e
Pull out ASW SDK version string into a property
jyemin 93d7069
Support AWS SDK v1
jyemin f225a6b
Support testing all AWS credential providers for ECS tests
jyemin 3e7e3c2
Cleanup
jyemin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 changes: 42 additions & 0 deletions
42
driver-core/src/main/com/mongodb/internal/authentication/AwsSdkV1CredentialSupplier.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| /* | ||
| * Copyright 2008-present MongoDB, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.mongodb.internal.authentication; | ||
|
|
||
| import com.amazonaws.auth.AWSCredentials; | ||
| import com.amazonaws.auth.AWSCredentialsProvider; | ||
| import com.amazonaws.auth.AWSSessionCredentials; | ||
| import com.amazonaws.auth.DefaultAWSCredentialsProviderChain; | ||
| import com.mongodb.AwsCredential; | ||
|
|
||
| import java.util.function.Supplier; | ||
|
|
||
| public final class AwsSdkV1CredentialSupplier implements Supplier<AwsCredential> { | ||
|
|
||
| private final AWSCredentialsProvider provider = DefaultAWSCredentialsProviderChain.getInstance(); | ||
|
|
||
| @Override | ||
| public AwsCredential get() { | ||
| AWSCredentials credentials = provider.getCredentials(); | ||
| if (credentials instanceof AWSSessionCredentials) { | ||
| AWSSessionCredentials sessionCredentials = (AWSSessionCredentials) credentials; | ||
| return new AwsCredential(sessionCredentials.getAWSAccessKeyId(), sessionCredentials.getAWSSecretKey(), | ||
| sessionCredentials.getSessionToken()); | ||
| } else { | ||
| return new AwsCredential(credentials.getAWSAccessKeyId(), credentials.getAWSSecretKey(), null); | ||
| } | ||
| } | ||
| } |
42 changes: 42 additions & 0 deletions
42
driver-core/src/main/com/mongodb/internal/authentication/AwsSdkV2CredentialSupplier.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| /* | ||
| * Copyright 2008-present MongoDB, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.mongodb.internal.authentication; | ||
|
|
||
| import com.mongodb.AwsCredential; | ||
| import software.amazon.awssdk.auth.credentials.AwsCredentials; | ||
| import software.amazon.awssdk.auth.credentials.AwsCredentialsProvider; | ||
| import software.amazon.awssdk.auth.credentials.AwsSessionCredentials; | ||
| import software.amazon.awssdk.auth.credentials.DefaultCredentialsProvider; | ||
|
|
||
| import java.util.function.Supplier; | ||
|
|
||
| public final class AwsSdkV2CredentialSupplier implements Supplier<AwsCredential> { | ||
|
|
||
| private final AwsCredentialsProvider provider = DefaultCredentialsProvider.create(); | ||
|
|
||
| @Override | ||
| public AwsCredential get() { | ||
| AwsCredentials credentials = provider.resolveCredentials(); | ||
| if (credentials instanceof AwsSessionCredentials) { | ||
| AwsSessionCredentials sessionCredentials = (AwsSessionCredentials) credentials; | ||
| return new AwsCredential(sessionCredentials.accessKeyId(), sessionCredentials.secretAccessKey(), | ||
| sessionCredentials.sessionToken()); | ||
| } else { | ||
| return new AwsCredential(credentials.accessKeyId(), credentials.secretAccessKey(), null); | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.