Cache Azure credential obtained from environment #1038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyemin
commented
Nov 5, 2022
| String accessToken; | ||
| Optional<String> cachedValue = cachedAccessToken.getValue(); | ||
| if (cachedValue.isPresent()) { | ||
| accessToken = cachedValue.get(); |
There was a problem hiding this comment.
This is the only untested line
driver-core/src/main/com/mongodb/internal/authentication/AzureCredentialHelper.java
Show resolved
Hide resolved
| } | ||
| accessToken = responseDocument.getString(ACCESS_TOKEN_FIELD).getValue(); | ||
| int expiresInSeconds = Integer.parseInt(responseDocument.getString(EXPIRES_IN_FIELD).getValue()); | ||
| cachedAccessToken = ExpirableValue.unexpired(accessToken, Duration.ofSeconds(expiresInSeconds).minus(Duration.ofMinutes(1))); |
There was a problem hiding this comment.
Create the new cached access token with the expiration as the duration from the HTTP response minus one minute
stIncMale
approved these changes
Nov 5, 2022
… Duration is <=0 Added another not-null assertion Added a few more tests
driver-core/src/main/com/mongodb/internal/authentication/AzureCredentialHelper.java
Outdated
Show resolved
Hide resolved
stIncMale
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA-4706