-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Added range index support for queryable encryption #1069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Note: The Range algorithm is experimental only. It is not intended for public use. It is subject to breaking changes. JAVA-4625
I'll review the build errors once the version is fixed. |
build.gradle
Outdated
// includeGroup "org.mongodb" | ||
// } | ||
// } | ||
maven { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a temp change. Will revert once libmongocrypt 1.7.0 binding have been pushed.
* @see <a href="https://code-case.hashnode.dev/how-to-pass-parameterized-test-parameters-to-beforeeachaftereach-method-in-junit5">AfterBeforeParameterResolver</a> | ||
* @see <a href="https://github.com/junit-team/junit5/issues/944">junit-team/junit5#944</a> | ||
*/ | ||
public class AfterBeforeParameterResolver implements BeforeEachMethodAdapter, ParameterResolver { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is quite fun for parameterized tests that require the parameters in the before / after methods.
protected abstract ClientEncryption createClientEncryption(ClientEncryptionSettings settings); | ||
|
||
@BeforeEach | ||
public void setUp(final Type type) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The AfterBeforeParameterResolver
provides the type to the setup method!
} | ||
|
||
@ParameterizedTest(name = "[{0}] Case 1: can decrypt a payload") | ||
@EnumSource(Type.class) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested for each type of Type!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't reviewed the tests yet but wanted to provide feedback on the API first.
driver-core/src/main/com/mongodb/client/model/vault/RangeOptions.java
Outdated
Show resolved
Hide resolved
driver-sync/src/main/com/mongodb/client/vault/ClientEncryption.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Added @kevinAlbs to make sure we didn't miss anything.
driver-core/src/main/com/mongodb/client/model/vault/RangeOptions.java
Outdated
Show resolved
Hide resolved
Any idea what's causing the CI failures? Oh, it's the mongodb-crypt library. I thought it would have been able to grab a snapshot from Sonatype |
Thankfully, the build is much happier - rerunning the one task that failed. |
Note: The Range algorithm is experimental only.
It is not intended for public use.
It is subject to breaking changes.
JAVA-4625