PojoCodec BsonId error message #1071
Conversation
Help users when using a BsonId in a constructor and there is no known Id property in the model. JAVA-4838
|
Ah I thought I had added a strike through of the original idea. I have clarified the ticket and the reason not to support it for decoding. |
| private final long longField; | ||
|
|
||
| @BsonCreator | ||
| public CreatorConstructorNoKnownIdModel( |
There was a problem hiding this comment.
Is the difference between this and the similar
@BsonCreator
public CreatorConstructorIdModel(@BsonId final String id,
@BsonProperty("integersField") final List<Integer> integerField,
@BsonProperty("longField") final long longField)
just that in this existing one the property is named id and the BsonId annotation is ignored? Is that why this one doesn't throw an exception?
I wonder why we allowed ElementType.PARAMETER as a target for BsonId in the first place... This is the only place I see it used as a parameter.
There was a problem hiding this comment.
CreatorConstructorIdModel has a public getId() method. The PojoCodec considers either id or _id properties as the id property. So in that case it can map to id.
I believe parameter support was added via a PR in JAVA-2599.
To be fair this is an edge case scenario and prevents a possible NPE.
Help users when using a BsonId in a constructor and there is no known Id property in the model.
JAVA-4838