-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update the legacy uber packages pom.xml #1076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update the name and description to indicate these are legacy and not the most recent release. JAVA-4854
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we do the same for async (and suggest reactive streams)?
@jyemin good idea - also update embedded description as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some concern that this will cause a different confusion for users. If they are using mongo-java-driver or mongodb-driver with the legacy API (com.mongodb.MongoClient), and they just switch to mongodb-driver-sync, they will be confused because what they really need is mongodb-driver-legacy. What do you think about mentioning that artifact as well?
CC @ashni-mongodb
Its a tricky one - saying this is a legacy driver and then suggesting another legacy driver might also be confusing :( |
Maybe we shouldn't call the 3.x driver legacy? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hmm agreed that there might be confusion marking this as legacy. What if we call it unsupported or unmaintained so that we can retain the "legacy" language for the "mongodb-driver-legacy" artifact? Something like this, maybe? "This driver is no longer maintained / updated by MongoDB. For the most up-to-date version of the Java Driver, please see mongodb-driver-sync. To use the legacy API, please refer to mongodb-driver-legacy." |
Maybe "this artifact" instead of "this driver". And use the work artifact as a suffix for all the names, so it's clear what we're talking about. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good. Ship it!
Update the name and description to indicate these are legacy and not the most recent release.
JAVA-4854