Fix the "database name is too long" error that happens when running against Serverless #1082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gainst Serverless JAVA-4679
rozza
approved these changes
Feb 10, 2023
katcharov
requested changes
Feb 10, 2023
| @@ -88,7 +88,7 @@ public void setUp() { | |||
| provider -> provider.name, provider -> provider.propertiesSupplier))) | |||
| .build()); | |||
| client.getDatabase(KEY_VAULT_NAMESPACE.getDatabaseName()).drop(); | |||
| db = client.getDatabase(AbstractClientSideEncryptionAutoDataKeysTest.class.getSimpleName()); | |||
| db = client.getDatabase("test"); | |||
There was a problem hiding this comment.
Perhaps this should substring the first n characters of the test name instead? (I assume we use the original convention to match up databases with tests.)
There was a problem hiding this comment.
There is no convention for test namespaces. Renamed to autoDataKeysTest, which may be better than an abrupt cut-off that potentially tears a word apart.
stIncMale
deleted the
JAVA-4679_fix_database_name_too_long_on_serverless
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA-4679