Kotlinx serialization decoding optional ObjectId / BsonValues fails to hydrate properly #1143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o hydrate The DefaultBsonDecoder required extra handling to ensure it did not double decode optional values and overwrite them with a null value. Tracking currentIndex and processed status allows the default decoder to correctly track if all elements have been processed and report the correct value when calling decodeElementIndex. JAVA-5031
jyemin
reviewed
Jun 17, 2023
| fun testDataClassWithOptionalObjectIdAndBsonDocument() { | ||
| val subDocument = | ||
| """{ | ||
| | "_id": 1, |
There was a problem hiding this comment.
It's not clear to me why it's necessary to test with such a complex subdocument. What's being tested by this? The fact that I don't know makes me think I don't understand the issue.
There was a problem hiding this comment.
The subdocument is just copy-pasta.
I'll update the tests and move to a val.
|
Updated the test cases and simplified the decoder.
|
jyemin
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found when writing the documentation:
The DefaultBsonDecoder required extra handling to ensure it did not try to double decode optional values and overwrite them with a null value.
Tracking currentIndex and processed status allows the default decoder to correctly track if all elements have been processed and report the correct value when calling decodeElementIndex.
JAVA-5031