CSOT: Added timeout to settings & connection string #1173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I tried to remain consistent with the rest of the code. So added the |
katcharov
approved these changes
Aug 16, 2023
| @@ -280,6 +282,7 @@ public class ConnectionString { | |||
| private Integer maxConnectionLifeTime; | |||
| private Integer maxConnecting; | |||
| private Integer connectTimeout; | |||
| private Long timeout; | |||
There was a problem hiding this comment.
should this have the unit, timeoutMS?
Perhaps it is ok if this is inconsistent with the others, since they are deprecated, and this is consistent with the suffixing elsewhere? In any case, the docs on the method should probably use the term "milliseconds".
There was a problem hiding this comment.
Added to the javadocs its milliseconds. Its annoying that its inconsistent but I opted to keep it consistently inconsistent as not all timeouts will be deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA-4064