Convert legacy retryable reads tests to unified format #1330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyemin
force-pushed
the
j5344
branch
3 times, most recently
from
08461dc to
9fe221b
Compare
rozza
reviewed
May 15, 2024
| } | ||
|
|
||
| public static void customSkips(final String fileDescription, @SuppressWarnings("unused") final String testDescription) { | ||
| assumeFalse(fileDescription.equals("count")); |
There was a problem hiding this comment.
Perhaps add a comment why these are skipped.
| import org.bson.{ BsonArray, BsonDocument, BsonString } | ||
| import org.mongodb.scala.syncadapter.SyncMongoClient | ||
|
|
||
| class RetryableReadsTests( |
There was a problem hiding this comment.
Is there a unified test for Scala now?
There was a problem hiding this comment.
No. Given that Kotlin, Kotlin co-routine, and Scala are all thin wrappers around the Java-based drivers, I don't think it's worth it to test retryable reads against all of them, as all the logic that's being tested lives in driver-core and is well-tested by the test runners for sync and reactive drivers.
Comparing with the other unified tests, I see only UnifiedCrudTest for kotlin-coroutine and kotlin-sync, so this seems in line with previous decisions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA-5344