Skip to content

Override collection/database with infinite timeout. #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

vbabanin
Copy link
Member

@vbabanin vbabanin requested a review from rozza March 21, 2024 01:35
@rozza
Copy link
Member

rozza commented Mar 21, 2024

I think #1349 may supersede this ticket - have you taken a look?

@vbabanin
Copy link
Member Author

vbabanin commented Apr 11, 2024

@rozza, based on my review, it appears that PR #1349 focuses mainly on introducing a new API and refactoring the code, specifically having changes to TimeoutHelper, without directly resolving the issue in this PR.

Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

# Conflicts:
#	driver-reactive-streams/src/main/com/mongodb/reactivestreams/client/internal/TimeoutHelper.java
#	driver-sync/src/main/com/mongodb/client/internal/TimeoutHelper.java
# Conflicts:
#	driver-reactive-streams/src/main/com/mongodb/reactivestreams/client/internal/TimeoutHelper.java
@vbabanin vbabanin merged commit 235adf4 into mongodb:CSOT Apr 18, 2024
55 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants