CSOT: Ignore wTimeoutMS #1368
Merged
CSOT: Ignore wTimeoutMS #1368
+234
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAVA-4062
# Conflicts: # driver-core/src/main/com/mongodb/internal/async/function/RetryState.java # driver-sync/src/test/functional/com/mongodb/client/ClientSideOperationTimeoutTest.java
vbabanin
commented
Apr 17, 2024
| @@ -25,7 +25,7 @@ | |||
| import java.util.function.Supplier; | |||
|
|
|||
| /** | |||
| * <p>Design by contract assertions.</p> <p>This class is not part of the public API and may be removed or changed at any time.</p> | |||
There was a problem hiding this comment.
This statement appears to be a duplicate of the one found on line 36.
vbabanin
commented
Apr 17, 2024
| @@ -203,7 +203,7 @@ private void doAdvanceOrThrow(final Throwable attemptException, | |||
| */ | |||
| if (hasTimeoutMs() && !loopState.isLastIteration()) { | |||
| previouslyChosenException = createMongoTimeoutException( | |||
| "MongoDB operation timed out during a retry attempt", | |||
| "Retry attempt timed out.", | |||
| previouslyChosenException); | |||
| } | |||
There was a problem hiding this comment.
The retry could be triggered not only by transient errors in MongoDB operations but also within the scope of OIDC. Referring to it as a 'MongoDB operation' might lead to confusion among users.
JAVA-4062
vbabanin
commented
Apr 19, 2024
| @Tag("setsFailPoint") | ||
| @Test | ||
| @DisplayName("Should ignore wTimeoutMS of WriteConcern to initial and subsequent commitTransaction operations") | ||
| @Disabled //TODO JAVA-5425 |
There was a problem hiding this comment.
An observation from JAVA-5425: TimeoutContext is null in subsequent commitTransaction operations.
rozza
approved these changes
Apr 19, 2024
| @@ -228,4 +238,8 @@ protected TimeoutSettings getTimeoutSettings(final TransactionOptions transactio | |||
| .withMaxCommitMS(transactionOptions.getMaxCommitTime(MILLISECONDS)) | |||
| .withTimeout(timeoutMS, MILLISECONDS); | |||
| } | |||
|
|
|||
| protected enum TransactionState { | |||
| @Tag("setsFailPoint") | ||
| @Test | ||
| @DisplayName("Should ignore wTimeoutMS of WriteConcern to initial and subsequent commitTransaction operations") | ||
| @Disabled //TODO JAVA-5425 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA-4062