-
Notifications
You must be signed in to change notification settings - Fork 1.5k
CSOT: Ignore wTimeoutMS #1368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSOT: Ignore wTimeoutMS #1368
Conversation
JAVA-4062
# Conflicts: # driver-core/src/main/com/mongodb/internal/async/function/RetryState.java # driver-sync/src/test/functional/com/mongodb/client/ClientSideOperationTimeoutTest.java
@@ -25,7 +25,7 @@ | |||
import java.util.function.Supplier; | |||
|
|||
/** | |||
* <p>Design by contract assertions.</p> <p>This class is not part of the public API and may be removed or changed at any time.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This statement appears to be a duplicate of the one found on line 36.
@@ -203,7 +203,7 @@ private void doAdvanceOrThrow(final Throwable attemptException, | |||
*/ | |||
if (hasTimeoutMs() && !loopState.isLastIteration()) { | |||
previouslyChosenException = createMongoTimeoutException( | |||
"MongoDB operation timed out during a retry attempt", | |||
"Retry attempt timed out.", | |||
previouslyChosenException); | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The retry could be triggered not only by transient errors in MongoDB operations but also within the scope of OIDC. Referring to it as a 'MongoDB operation
' might lead to confusion among users.
JAVA-4062
@Tag("setsFailPoint") | ||
@Test | ||
@DisplayName("Should ignore wTimeoutMS of WriteConcern to initial and subsequent commitTransaction operations") | ||
@Disabled //TODO JAVA-5425 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An observation from JAVA-5425: TimeoutContext is null in subsequent commitTransaction operations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -228,4 +238,8 @@ protected TimeoutSettings getTimeoutSettings(final TransactionOptions transactio | |||
.withMaxCommitMS(transactionOptions.getMaxCommitTime(MILLISECONDS)) | |||
.withTimeout(timeoutMS, MILLISECONDS); | |||
} | |||
|
|||
protected enum TransactionState { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@Tag("setsFailPoint") | ||
@Test | ||
@DisplayName("Should ignore wTimeoutMS of WriteConcern to initial and subsequent commitTransaction operations") | ||
@Disabled //TODO JAVA-5425 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
JAVA-4062