-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Mark CSOT feature as Alpha #1372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
JAVA-5402
JAVA-5402
JAVA-5402
JAVA-5402
3) The following files: Beta.java, UnsignedLongs.java, UnsignedLongsTest.java | ||
3) The following files: | ||
|
||
Alpha.java (formerly Beta.java) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation in Alpha.java
references Javadoc wording from our Beta
annotation, which itself incorporates wording from Guava's Beta.java.
Because of this transitive relationship: Alpha -> Beta -> Guava's Beta, copyright for Alpha.java was added here.
…ttings. JAVA-5402
JAVA-5402
JAVA-5402
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
I noted a few missing annotations on getTimeout
methods, but please double-check that they are all annotated.
driver-reactive-streams/src/main/com/mongodb/reactivestreams/client/MongoCluster.java
Outdated
Show resolved
Hide resolved
driver-reactive-streams/src/main/com/mongodb/reactivestreams/client/MongoDatabase.java
Outdated
Show resolved
Hide resolved
JAVA-5402
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
driver-scala/src/main/scala/org/mongodb/scala/gridfs/GridFSBucket.scala
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/MongoOperationTimeoutException.java
Outdated
Show resolved
Hide resolved
- Mode Reason to top-level class. - Change JavaDoc of Alpha annotation for better accuracy. JAVA-5402
# Conflicts: # driver-reactive-streams/src/main/com/mongodb/reactivestreams/client/AggregatePublisher.java # driver-reactive-streams/src/main/com/mongodb/reactivestreams/client/DistinctPublisher.java
JAVA-5402
driver-kotlin-sync/src/main/kotlin/com/mongodb/kotlin/client/FindIterable.kt
Show resolved
Hide resolved
Co-authored-by: Valentin Kovalenko <[email protected]>
- Mark timeoutMode with Alpha annotation JAVA-5402
JAVA-5402
Description
This PR designates the CSOT API as Alpha for experimental use.
Additionally, it introduces the Alpha annotation. While initially utilized within the CSOT API, the annotation's Javadoc covers broader context beyond CSOT.
JAVA-5402