CSOT: Adjust timeouts and increase test coverage #1383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAVA-5104
Rename tests for better clarity. JAVA-5104
Use unified terminiogy for timeout messages. JAVA-5104
JAVA-5104
JAVA-5104
JAVA-5104
JAVA-5104
…sue. - Adress static check issues. JAVA-5104
…s instances. JAVA-5104
vbabanin
changed the title
rozza
reviewed
May 23, 2024
| @@ -97,9 +100,6 @@ | |||
| { | |||
| "name": "commitTransaction", | |||
| "object": "session", | |||
| "arguments": { | |||
| "timeoutMS": 500 | |||
There was a problem hiding this comment.
Whats the reasoning for this change?
There was a problem hiding this comment.
I have reverted this change as we don't have overrides. Thank you for pointing it out!
| * Not a prose spec test. However, it is additional test case for better coverage. | ||
| */ | ||
| @Test | ||
| @DisplayName("Should refresh timeout for commit transaction") |
There was a problem hiding this comment.
How does this test check that the timeout is refreshed? Seems to just confirm that the second commit fail with MongoOperationTimeoutException?
There was a problem hiding this comment.
I have corrected the DisplayName to be Should throw timeout exception for subsequent commit transaction. Good catch, thanks!
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "description": "timeoutMS behaves correctly for non-tailable cursors", | |||
| "comment": "Manually reduced blockTimeMS for tests to pass in serverless", | |||
| @@ -107,7 +105,6 @@ protected boolean isAsync() { | |||
| return true; | |||
| } | |||
|
|
|||
| @Tag("setsFailPoint") | |||
- Rename test name.
# Conflicts: # driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedTest.java
rozza
reviewed
Jun 3, 2024
| @@ -742,10 +732,53 @@ public void shouldIgnoreWtimeoutMsOfWriteConcernToInitialAndSubsequentCommitTran | |||
| if (command.containsKey("writeConcern")) { | |||
| BsonDocument writeConcern = command.getDocument("writeConcern"); | |||
| assertFalse(writeConcern.isEmpty()); | |||
| assertFalse(writeConcern.containsKey("wTimeoutMS")); | |||
| assertFalse(writeConcern.containsKey("wtimeout")); | |||
# Conflicts: # driver-sync/src/test/functional/com/mongodb/client/AbstractClientSideOperationsTimeoutProseTest.java # driver-sync/src/test/functional/com/mongodb/client/ClientSideOperationTimeoutTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the following changes:
JAVA-5104