Remove RTT check before reading a response from the server. #1391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbabanin
commented
May 15, 2024
| @@ -509,6 +502,16 @@ private <T> void sendCommandMessageAsync(final int messageId, final Decoder<T> d | |||
| final SingleResultCallback<T> callback, final ByteBufferBsonOutput bsonOutput, | |||
| final CommandEventSender commandEventSender, final boolean responseExpected) { | |||
| List<ByteBuf> byteBuffers = bsonOutput.getByteBuffers(); | |||
|
|
|||
| boolean[] shouldReturn = {false}; | |||
There was a problem hiding this comment.
I've moved this check from "after the write is complete" to "before a message is send."
According to the CSOT spec:
After wire message construction, drivers MUST check for timeout before writing the message to the server.
vbabanin
commented
May 15, 2024
| @@ -349,9 +349,6 @@ public <T> T sendAndReceive(final CommandMessage message, final Decoder<T> decod | |||
| CommandEventSender commandEventSender; | |||
|
|
|||
| try (ByteBufferBsonOutput bsonOutput = new ByteBufferBsonOutput(this)) { | |||
| Timeout.onExistsAndExpired(operationContext.getTimeoutContext().timeoutIncludingRoundTrip(), () -> { | |||
There was a problem hiding this comment.
According to the specification:
After wire message construction, drivers MUST check for timeout before writing the message to the server.
I have removed this check from its previous position as it was occurring before the wire message was constructed, not after, which is contrary to the spec. We still perform this necessary timeout check later in the code within the trySendMessage method, just before writing the message to the socket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA-5473