-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Create and upload ssdlc_compliance_report.md
#1405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2a5f103
to
068ed0c
Compare
JAVA-5435
@rtimmons if you have the time please give this PR a look. |
JAVA-5435
JAVA-5435
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one request, otherwise LGTM
template_ssdlc_compliance_report.md
Outdated
@@ -0,0 +1,82 @@ | |||
# ${product_name} SSDLC compliance report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we hide this file inside the .evergreen
directory. It seems too prominent at the top level like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 06ec2e9.
JAVA-5435
Go to | ||
<a href="https://papertrail.devprod-infra.prod.corp.mongodb.com/product-version?product=${product_name}&version=${product_version}"> | ||
https://papertrail.devprod-infra.prod.corp.mongodb.com/product-version?product=${product_name}&version=${product_version}</a>, | ||
look at the value in the "Submitter" column. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dylrich are we comfortable with this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're going to include these links in the report, maybe we should pull their templates from Evergreen project properties instead of checking them in to the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The UI has no long-term stability guarantees and is intended purely for debugging. It's not an Official(tm) product we support. We have not received direction on an official way to serve Papertrail data yet. I'd be more comfortable with language that says something more vague like "see Papertrail"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 98c5113.
JAVA-5435
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The SSDLC artifacts are created and uploaded to an AWS S3 bucket when we run either
publish-snapshot
orpublish-release
Evergreen task. An example of the report is here, it was created by thispublish-snapshot
run.JAVA-5435