Sync up transaction specs #1539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanQingyangXu
force-pushed
the
transaction-specs
branch
2 times, most recently
from
42c57ff to
0bb0597
Compare
NathanQingyangXu
force-pushed
the
transaction-specs
branch
from
0bb0597 to
1fda150
Compare
jyemin
requested changes
Oct 30, 2024
| @@ -2004,6 +2004,104 @@ | |||
| } | |||
| ] | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Let's revert this change (and the associated skip of the tests) to save Valentin the hassle of a merge conflict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.