Skip to content

Tidy up BULK-TODOs #1599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Tidy up BULK-TODOs #1599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions driver-scala/src/integration/scala/org/mongodb/scala/syncadapter/SyncMongoCluster.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,32 +130,32 @@ class SyncMongoCluster(wrapped: MongoCluster) extends JMongoCluster {
override def bulkWrite(
models: util.List[_ <: ClientNamespacedWriteModel]
): ClientBulkWriteResult = {
org.junit.Assume.assumeTrue("BULK-TODO implement", java.lang.Boolean.parseBoolean(toString))
throw Assertions.fail("BULK-TODO implement")
org.junit.Assume.assumeTrue("TODO-JAVA-5531 implement", java.lang.Boolean.parseBoolean(toString))
throw Assertions.fail("TODO-JAVA-5531 implement")
}

override def bulkWrite(
models: util.List[_ <: ClientNamespacedWriteModel],
options: ClientBulkWriteOptions
): ClientBulkWriteResult = {
org.junit.Assume.assumeTrue("BULK-TODO implement", java.lang.Boolean.parseBoolean(toString))
throw Assertions.fail("BULK-TODO implement")
org.junit.Assume.assumeTrue("TODO-JAVA-5531 implement", java.lang.Boolean.parseBoolean(toString))
throw Assertions.fail("TODO-JAVA-5531 implement")
}

override def bulkWrite(
clientSession: ClientSession,
models: util.List[_ <: ClientNamespacedWriteModel]
): ClientBulkWriteResult = {
org.junit.Assume.assumeTrue("BULK-TODO implement", java.lang.Boolean.parseBoolean(toString))
throw Assertions.fail("BULK-TODO implement")
org.junit.Assume.assumeTrue("TODO-JAVA-5531 implement", java.lang.Boolean.parseBoolean(toString))
throw Assertions.fail("TODO-JAVA-5531 implement")
}

override def bulkWrite(
clientSession: ClientSession,
models: util.List[_ <: ClientNamespacedWriteModel],
options: ClientBulkWriteOptions
): ClientBulkWriteResult = {
org.junit.Assume.assumeTrue("BULK-TODO implement", java.lang.Boolean.parseBoolean(toString))
throw Assertions.fail("BULK-TODO implement")
org.junit.Assume.assumeTrue("TODO-JAVA-5531 implement", java.lang.Boolean.parseBoolean(toString))
throw Assertions.fail("TODO-JAVA-5531 implement")
}
}
2 changes: 1 addition & 1 deletion driver-scala/src/test/scala/org/mongodb/scala/ApiAliasAndCompanionSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ class ApiAliasAndCompanionSpec extends BaseSpec {
.map(_.getSimpleName)
.toSet +
"MongoException" - "MongoGridFSException" - "MongoConfigurationException" - "MongoWriteConcernWithResponseException" -
// BULK-TODO remove this exclusion
// TODO-JAVA-5531 remove the `"ClientBulkWriteException"` exclusion
"ClientBulkWriteException"

val objects = new Reflections(
Expand Down
4 changes: 2 additions & 2 deletions driver-scala/src/test/scala/org/mongodb/scala/MongoClientSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,11 @@ class MongoClientSpec extends BaseSpec with MockitoSugar {
wrapped.foreach((name: String) => {
val cleanedName = name.stripPrefix("get")

// TODO("BULK-TODO remove this if when bulkWrite is implemented and uncomment line 43")
if (!cleanedName.contains("bulkWrite")) {
// TODO-JAVA-5531 remove this whole `if` block
assert(local.contains(name) | local.contains(cleanedName.head.toLower + cleanedName.tail), s"Missing: $name")
}
// assert(local.contains(name) | local.contains(cleanedName.head.toLower + cleanedName.tail), s"Missing: $name")
// TODO-JAVA-5531 uncomment: assert(local.contains(name) | local.contains(cleanedName.head.toLower + cleanedName.tail), s"Missing: $name")
})
}

Expand Down