-
Notifications
You must be signed in to change notification settings - Fork 1.5k
CSOT refactoring #1781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vbabanin
wants to merge
17
commits into
mongodb:main
Choose a base branch
from
vbabanin:JAVA-5640
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
CSOT refactoring #1781
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
a19be26
Rename operationTimeout
katcharov 489d6d9
Remove doWithResetTimeout
katcharov fedc764
Remove resetTimeoutIfPresent from CommandBatchCursor
katcharov 3a81c61
Remove Timeout from RetryState
katcharov ad5937c
Decouple OperationContext from BindingContext.
vbabanin 29750df
Merge branch 'main' into JAVA-5640
vbabanin 353099b
Update logback-test.xml
vbabanin 2b33520
Fix compilation errors.
vbabanin cddd29a
Merge branch 'main' into JAVA-5640
vbabanin c742581
Add javadoc, remove comments.
vbabanin ab49280
Remove redundant tests.
vbabanin 3c6040a
Enhance Javadoc comments and improve method signatures for clarity.
vbabanin c21a67f
Remove comments.
vbabanin 863293f
Rename methods.
vbabanin 6059fc4
Add support for awaiting CommandStartedEvent in Unified Test Runner.
vbabanin 53c339f
Revert "Add support for awaiting CommandStartedEvent in Unified Test …
vbabanin e245820
Merge branch 'main' into JAVA-5640
rozza File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
367 changes: 198 additions & 169 deletions
367
driver-core/src/main/com/mongodb/internal/TimeoutContext.java
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 changes: 42 additions & 0 deletions
42
driver-core/src/main/com/mongodb/internal/async/function/AsyncCallbackTriFunction.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
/* | ||
* Copyright 2008-present MongoDB, Inc. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package com.mongodb.internal.async.function; | ||
|
||
import com.mongodb.internal.async.SingleResultCallback; | ||
import com.mongodb.lang.Nullable; | ||
|
||
/** | ||
* An {@linkplain AsyncCallbackFunction asynchronous callback-based function} of three parameters. | ||
* This class is a callback-based. | ||
* | ||
* <p>This class is not part of the public API and may be removed or changed at any time</p> | ||
* | ||
* @param <P1> The type of the first parameter to the function. | ||
* @param <P2> The type of the second parameter to the function. | ||
* @param <P3> The type of the third parameter to the function. | ||
* @param <R> See {@link AsyncCallbackFunction} | ||
* @see AsyncCallbackFunction | ||
*/ | ||
@FunctionalInterface | ||
public interface AsyncCallbackTriFunction<P1, P2, P3, R> { | ||
/** | ||
* @param p1 The first {@code @}{@link Nullable} argument of the asynchronous function. | ||
* @param p2 The second {@code @}{@link Nullable} argument of the asynchronous function. | ||
* @param p3 The second {@code @}{@link Nullable} argument of the asynchronous function. | ||
* @see AsyncCallbackFunction#apply(Object, SingleResultCallback) | ||
*/ | ||
void apply(P1 p1, P2 p2, P3 p3, SingleResultCallback<R> callback); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Authenticator
has aoperationContextWithoutSession
helper method, should this be DRY'd up and shared? The pattern seems to be repeated throught out the code.