PYTHON-2723 Make mongos_clients a class property #1563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I opened https://jira.mongodb.org/browse/PYTHON-4303 for the other failures. |
ShaneHarvey
approved these changes
Mar 27, 2024
|
Wait is the problem that astrolabe never runs setUpClass()? https://github.com/mongodb-labs/drivers-atlas-testing/blob/93925b2/integrations/python/pymongo/workload-executor.py#L32-L36 Edit: Calling setUpClass is arguably better but this change still LGTM to get the testing passing again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Astrolabe failure: https://spruce.mongodb.com/task/drivers_atlas_testing_tests_python__driver~pymongo_master_platform~ubuntu_22.04_runtime~python39_atlas_retryWrites_resizeCluster_6603d586d05b2a00076119d2_24_03_27_08_15_02/logs?execution=0