RUBY-1894 Clear connection pools when monitor ismaster times out #1475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HanaPearlman
approved these changes
Aug 5, 2019
p-mongo
added a commit
to p-mongo/mongo-ruby-driver
that referenced
this pull request
Aug 5, 2019
… out (mongodb#1475) * Clear server pool when a server is marked unknown * Comment out tests that are no longer applicable * Integration test for pool being cleared on network errors and timeouts in monitor * improve test reliability * try lower timeouts * Retry all monitoring tests
p-mongo
added a commit
to p-mongo/mongo-ruby-driver
that referenced
this pull request
Aug 5, 2019
… out (mongodb#1475) This version always clears connection pools whenever a server becomes unknown. This results in repeated pool clears sometimes which is suboptimal but not really wrong. Driver version 2.11+ has the correct implementation of pool clearing which makes use of refactoring done for background connection pool thread/SRV polling.
p-mongo
added a commit
to p-mongo/mongo-ruby-driver
that referenced
this pull request
Aug 6, 2019
… out (mongodb#1475) This version always clears connection pools whenever a server becomes unknown. This results in repeated pool clears sometimes which is suboptimal but not really wrong. Driver version 2.11+ has the correct implementation of pool clearing which makes use of refactoring done for background connection pool thread/SRV polling.
p-mongo
added a commit
to p-mongo/mongo-ruby-driver
that referenced
this pull request
Aug 6, 2019
… out (mongodb#1475) This version always clears connection pools whenever a server becomes unknown. This results in repeated pool clears sometimes which is suboptimal but not really wrong. Driver version 2.11+ has the correct implementation of pool clearing which makes use of refactoring done for background connection pool thread/SRV polling.
p-mongo
added a commit
that referenced
this pull request
Aug 6, 2019
… out (#1475) (#1477) This version always clears connection pools whenever a server becomes unknown. This results in repeated pool clears sometimes which is suboptimal but not really wrong. Driver version 2.11+ has the correct implementation of pool clearing which makes use of refactoring done for background connection pool thread/SRV polling.
p-mongo
added a commit
to p-mongo/mongo-ruby-driver
that referenced
this pull request
Aug 6, 2019
… out (mongodb#1475) (mongodb#1477) This version always clears connection pools whenever a server becomes unknown. This results in repeated pool clears sometimes which is suboptimal but not really wrong. Driver version 2.11+ has the correct implementation of pool clearing which makes use of refactoring done for background connection pool thread/SRV polling.
p-mongo
added a commit
that referenced
this pull request
Aug 6, 2019
… out (#1475) (#1477) (#1479) This version always clears connection pools whenever a server becomes unknown. This results in repeated pool clears sometimes which is suboptimal but not really wrong. Driver version 2.11+ has the correct implementation of pool clearing which makes use of refactoring done for background connection pool thread/SRV polling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.com/browse/RUBY-1894