Skip to content

We can't really handle SIGKILL so removing it. #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

We can't really handle SIGKILL so removing it. #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions signals/signals.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ func Handle() chan struct{} {
return HandleWithInterrupt(nil)
}

// HandleWithInterrupt starts a goroutine which listens for SIGTERM, SIGINT, and
// SIGKILL and explicitly ignores SIGPIPE. It calls the finalizer function when
// HandleWithInterrupt starts a goroutine which listens for SIGTERM and SIGINT, and
// explicitly ignores SIGPIPE. It calls the finalizer function when
// the first signal is received and forcibly terminates the program after the
// second. If a nil function is provided, the program will exit after the first
// signal.
Expand All @@ -37,9 +37,9 @@ func handleSignals(finalizer func(), finishedChan chan struct{}) {
noopChan := make(chan os.Signal)
signal.Notify(noopChan, syscall.SIGPIPE)

log.Logv(log.DebugLow, "will listen for SIGTERM, SIGINT, and SIGKILL")
log.Logv(log.DebugLow, "will listen for SIGTERM and SIGINT")
sigChan := make(chan os.Signal, 2)
signal.Notify(sigChan, syscall.SIGTERM, syscall.SIGINT, syscall.SIGKILL)
signal.Notify(sigChan, syscall.SIGTERM, syscall.SIGINT)
defer signal.Stop(sigChan)
if finalizer != nil {
select {
Expand Down