CLOUDP-225726: AtlasCLI Release Improvements: build .exe files only once #2682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
33
to
37
| BINARY_NAME="mongocli.exe" | ||
| if [[ "${TOOL_NAME:?}" == atlascli ]]; then | ||
| BINARY_NAME="atlas.exe" | ||
| fi | ||
|
|
There was a problem hiding this comment.
[nit] this does not need another if. you can add BINARY_NAME="atlas.exe" inside the previous if. Similarly, you can move BINARY_NAME="mongocli.exe" at line 27
There was a problem hiding this comment.
I noticed too late, pushed a fix
andreaangiolillo
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Deduplicate the windows build by using the prebuilt feature of goreleaser and re-using the build artifacts from the
pack_msistep.Jira ticket: CLOUDP-225726
Testing
Build here and verified on a windows host that the installer is still working properly.