Skip to content

CLOUDP-234440: Remove patch_optional because evergreen was not able to resolve it on git tags #2684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 29, 2024
Merged

CLOUDP-234440: Remove patch_optional because evergreen was not able to resolve it on git tags #2684

merged 1 commit into from
Feb 29, 2024

Conversation

fmenezes
Copy link
Collaborator

@fmenezes fmenezes commented Feb 29, 2024 •
edited
Loading

Proposed changes

Remove patch_optional because evergreen was not able to resolve it on git tags

Jira ticket: CLOUDP-234440

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@fmenezes fmenezes marked this pull request as ready for review February 29, 2024 15:17
@fmenezes fmenezes requested a review from a team February 29, 2024 15:17
gssbzn
gssbzn approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine this is a consequence of having the single task right?

Just so that we are aware of the implications this means for testing you gonna have to wait for compilation to pass before this task is able to run

@fmenezes fmenezes merged commit c994778 into master Feb 29, 2024
@fmenezes fmenezes deleted the CLOUDP-234440 branch February 29, 2024 15:48
@fmenezes fmenezes mentioned this pull request Apr 5, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

@jeroenvervaeke jeroenvervaeke jeroenvervaeke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fmenezes @gssbzn @jeroenvervaeke