Skip to content

CLOUDP-233673 Move Atlas Deployments tests #2692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2024
Merged

CLOUDP-233673 Move Atlas Deployments tests #2692

merged 2 commits into from
Mar 4, 2024

Conversation

fmenezes
Copy link
Collaborator

@fmenezes fmenezes commented Mar 4, 2024

Proposed changes

Move Atlas Deployments tests

Jira ticket: CLOUDP-233673

Closes #[issue number]

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@@ -229,35 +229,3 @@ func PublishSnapshotTasks(c *shrub.Configuration, toolName string) {
false,
)
}

func LocalDeploymentTasks(c *shrub.Configuration, toolName string) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

took the liberty to remove auto generated tests that were not running any way and had no value to add

@fmenezes fmenezes marked this pull request as ready for review March 4, 2024 15:02
@fmenezes fmenezes requested a review from a team March 4, 2024 15:03
@fmenezes fmenezes merged commit 540ec69 into master Mar 4, 2024
@fmenezes fmenezes deleted the CLOUDP-233673 branch March 4, 2024 15:22
@fmenezes fmenezes mentioned this pull request Apr 5, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants