CLOUDP-234527 Remove mongocli 2nd followup #2706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmenezes
changed the title
gssbzn
reviewed
Mar 5, 2024
| @@ -109,18 +109,11 @@ func ExampleAtlasEntryPoint() string { | |||
| return exampleBin | |||
| } | |||
| exampleBin = config.BinName() | |||
| if exampleBin == config.MongoCLI { | |||
There was a problem hiding this comment.
maybe worth dropping the function altogether but that may be a bigger PR, ok for a followup
gssbzn
reviewed
Mar 5, 2024
| return exampleBin | ||
| } | ||
|
|
||
| // DescriptionServiceName returns the name of the service that uses a given IAM command. | ||
| func DescriptionServiceName() string { | ||
| exampleBin = config.BinName() |
gssbzn
reviewed
Mar 5, 2024
internal/cli/root/atlas/builder.go
Outdated
| @@ -345,18 +344,18 @@ func (n *Notifier) notifyIfApplicable(isHb bool) error { | |||
|
|
|||
| var upgradeInstructions string | |||
| if isHb { | |||
| upgradeInstructions = fmt.Sprintf(`To upgrade, run "brew update && brew upgrade %s".`, homebrew.FormulaName(config.ToolName)) | |||
| upgradeInstructions = fmt.Sprintf(`To upgrade, run "brew update && brew upgrade %s".`, homebrew.FormulaName()) | |||
There was a problem hiding this comment.
same above, maybe worth removing the function
gssbzn
previously approved these changes
Mar 5, 2024
gssbzn
previously approved these changes
Mar 5, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Remove mongocli (followup from #2705), this is removing unused code and refactoring tool_name
Jira ticket: CLOUDP-234527
Closes #[issue number]
Checklist
make fmtand formatted my codeFurther comments