CLOUDP-236020 Rename go.mod to /atlascli and all references #2719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmenezes
commented
Mar 6, 2024
| @@ -47,7 +47,7 @@ gomod: # https://goreleaser.com/customization/verifiable_builds/ | |||
| # This will only be effective if running against a tag. Snapshots will ignore | |||
| # this setting. | |||
| # Notice: for this to work your `build.main` must be a package, not a `.go` file. | |||
| proxy: false # it will be enabled in CLOUDP-228737 | |||
| proxy: true | |||
There was a problem hiding this comment.
@gssbzn SBOM works but we will revert this once we move from atlascli/vX.Y.Z to vX.Y.Z, do you think it is still worth committing?
There was a problem hiding this comment.
I don't think we should rollback the versioning name, it opens too many questions for things like the update notifier that I think if this works we should live with it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Rename go.mod to /atlascli and all references
Jira ticket: CLOUDP-236020
Checklist
make fmtand formatted my codeFurther comments