task: unification of the stores part 3 #2734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gssbzn
commented
Mar 7, 2024
Comment on lines
-46
to
-51
| func TestDisableOpts_InitStore(t *testing.T) { | ||
| opts := &DisableOpts{} | ||
|
|
||
| require.NoError(t, opts.initStore(context.TODO())()) | ||
| assert.NotNil(t, opts.store) | ||
| } |
There was a problem hiding this comment.
we added a validation on the general store for the service and this now fails, deiced to remove since we never test this method
There was a problem hiding this comment.
same for all removals of this test in backup compliance
fmenezes
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving now backup compliance and api access list to the general store