-
Notifications
You must be signed in to change notification settings - Fork 87
CLOUDP-164347: Add --flag file
to the atlas cluster index create
command
#2768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… (e.g. indexes with collations) in Atlas CLI
@@ -107,6 +107,7 @@ dbName and collection are required only for built-in roles.` | |||
MaxDate = "Maximum created date. This option returns events whose created date is less than or equal to the specified value." | |||
MinDate = "Minimum created date. This option returns events whose created date is greater than or equal to the specified value." | |||
ClusterFilename = "Path to an optional JSON configuration file that defines cluster settings. To learn more about cluster configuration files for the Atlas CLI, see https://dochub.mongodb.org/core/cluster-config-file-atlascli. To learn more about cluster configuration files for MongoCLI, see https://dochub.mongodb.org/core/mms-cluster-settings-file-mcli." | |||
IndexFilename = "Path to an optional JSON configuration file that defines index settings." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you intend to have documentation for the file structure? if so make sure to ask for a dochub link and add it here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need the doc team to create the doc page and then we can update the description here. Let me know if I am missing something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can have the link ahead of time if you ask them and once the page is up they redirect it. we've done this way before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can alternatively open a docsp ticket and ask them to update this line, make sure to add a link to where they should add the link if that is the approach you prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, we cannot use the example in the open api spec (it does not work) and I haven't found any examples in the doc. The doc team will need to use the files in the data folders included in this PR 😭
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarahsimpers FYI as I think you've done some work here recently on the config files for the CLI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andreaangiolillo copy lgtm but I'd like Sarah to chime in on the config file issue
I created https://jira.mongodb.org/browse/DOCSP-37703 and included a description of what we will need on the doc side |
Proposed changes
Jira ticket: CLOUDP-164347
Checklist
make fmt
and formatted my codeFurther comments