Skip to content

CLOUDP-240596: fix search index create watcher for Atlas deployments #2821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

ciprian-tibulca
Copy link
Contributor

@ciprian-tibulca ciprian-tibulca commented Apr 2, 2024

@ciprian-tibulca ciprian-tibulca requested a review from a team April 2, 2024 13:10
blva
blva previously approved these changes Apr 2, 2024
Copy link
Collaborator

@blva blva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just cause we disabled the local tests, can you make sure to do a manual test of the local functionality to triple check all is fine? thanks!

@ciprian-tibulca
Copy link
Contributor Author

LGTM, just cause we disabled the local tests, can you make sure to do a manual test of the local functionality to triple check all is fine? thanks!

for local it's already checked here: https://spruce.mongodb.com/task/mongodb_atlas_cli_master_e2e_local_deployments_atlas_deployments_local_noauth_e2e_patch_07319bbad7ef2b9d622be191947b63f4efc256fd_660c03d3343b7100072f4269_24_04_02_13_10_46?execution=0&sortBy=STATUS&sortDir=ASC

@ciprian-tibulca ciprian-tibulca requested review from gssbzn and blva April 2, 2024 13:28
blva
blva previously approved these changes Apr 2, 2024
gssbzn
gssbzn previously approved these changes Apr 2, 2024
@ciprian-tibulca ciprian-tibulca dismissed stale reviews from gssbzn and blva via b79a98d April 2, 2024 14:18
@ciprian-tibulca ciprian-tibulca merged commit 4e8f1bf into master Apr 2, 2024
@ciprian-tibulca ciprian-tibulca deleted the CLOUDP-240596 branch April 2, 2024 14:41
@fmenezes fmenezes mentioned this pull request Apr 5, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants