Skip to content

Conversation

jeroenvervaeke
Copy link
Member

Proposed changes

Use go-driver search index management helpers instead of createSearchIndexCommand

CLOUDP-199915

@jeroenvervaeke jeroenvervaeke requested a review from a team May 24, 2024 12:49
@jeroenvervaeke jeroenvervaeke marked this pull request as draft May 24, 2024 12:59
@jeroenvervaeke
Copy link
Member Author

This PR is ready when mongodb/mongo-go-driver#1647 is merged.

Before merging, remove the override to my personal repo.

Copy link
Contributor

This PR has gone 30 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 30 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy!

@github-actions github-actions bot added the stale A stale issue or PR label Jun 27, 2024
@jeroenvervaeke jeroenvervaeke marked this pull request as ready for review June 28, 2024 11:53
@jeroenvervaeke
Copy link
Member Author

mongo-go-driver was released today, which includes the functionality to specify the search index type.
https://github.com/mongodb/mongo-go-driver/releases/tag/v1.16.0

@jeroenvervaeke jeroenvervaeke removed the stale A stale issue or PR label Jun 28, 2024
Copy link
Contributor

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if LGTEVG

@jeroenvervaeke jeroenvervaeke merged commit dfa44db into master Jun 28, 2024
@jeroenvervaeke jeroenvervaeke deleted the CLOUDP-199915 branch June 28, 2024 12:16
stefan4h pushed a commit that referenced this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants